This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization
- From: JiangNing OS <jiangning at os dot amperecomputing dot com>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Jul 2019 04:26:24 +0000
- Subject: [PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=os.amperecomputing.com;dmarc=pass action=none header.from=os.amperecomputing.com;dkim=pass header.d=os.amperecomputing.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tG+p1Tw4zXdhLtIm+rJjsu/XDyld4TZsVnIuJ37oUJ4=; b=RbAVCH9tI8h1shfmEMFrJ/ZEHbwQROkq2WsTCjkGzJvEQ1dHdRIiPwVNL2Fvr5OGDqer0DKifd4AyZtHjB28aSsDly2vZ7WMaKGIsBkV0jB8dQCHEuW14F0SrLPJ731JOoKR9qCXQShNzS93gTJrAL0/sQUcbk+bMLJd+FwIM9vJalZBQcL10IXhkIAm7nXFtZMAvLeTahUYbPG+QHZOZr8rfyRqCBN1CpfoYWr/u/Ign3kzC65t7DKEdsR3RLe5hdzoHPVBn2EEW4k8vK3HiWUsPcflKIGxxxwUkyxfhk8IOhNm5cahMWHizqks6qu33JAe/Ur72UbDCjbQ+T1D3A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PL4n67yZ4t/9gxV36z2RFcIFrtLpbID6BU80w4L5Bplx64YQq2b4xj1rCtVKisa3bz18EZSbKlSdszBI6ogAZI10yRdF0HNejRTQJYMTRGLU21/JrVC3jcTpp0Mek6Gj08ZY51jtFLpwzZVd5QvBmFQp6XnXw562uCfp+SpRt0xnUqqeOX+Dk+Pw1fYOCcrKw6y4cEzJ6mSBBnktxjCPliMAFSi/13PYsCnZT0dfHRLDmf6qLEdW7liAOmN7G4S5mMGB4YRF/48RgVtxVDVU4gPUTQHUYXaQVhUdHSgtY0rBzTS2VY+3Q055hPH+nzK6mj/SWpnZod9vvdgfDDd8uA==
This patch is to fix PR91195. Is it OK for trunk?
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 711a31ea597..4db36644160 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-07-22 Jiangning Liu <jiangning.liu@amperecomputing.com>
+
+ PR middle-end/91195
+ * tree-ssa-phiopt.c (cond_store_replacement): Work around
+ -Wmaybe-uninitialized warning.
+
2019-07-22 Stafford Horne <shorne@gmail.com>
* config/or1k/or1k.c (or1k_expand_compare): Check for int before
diff --git a/gcc/tree-ssa-phiopt.c b/gcc/tree-ssa-phiopt.c
index b64bde695f4..7a86007d087 100644
--- a/gcc/tree-ssa-phiopt.c
+++ b/gcc/tree-ssa-phiopt.c
@@ -2240,6 +2240,14 @@ cond_store_replacement (basic_block middle_bb, basic_block join_bb,
tree base = get_base_address (lhs);
if (!auto_var_p (base) || TREE_ADDRESSABLE (base))
return false;
+
+ /* The transformation below will inherently introduce a memory load,
+ for which LHS may not be initialized yet if it is not in NOTRAP,
+ so a -Wmaybe-uninitialized warning message could be triggered.
+ Since it's a bit hard to have a very accurate uninitialization
+ analysis to memory reference, we disable the warning here to avoid
+ confusion. */
+ TREE_NO_WARNING (lhs) = 1;
}
/* Now we've checked the constraints, so do the transformation:
Thanks,
-Jiangning