This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op
- From: Andrea Corallo <Andrea dot Corallo at arm dot com>
- To: Andrea Corallo <Andrea dot Corallo at arm dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "jit at gcc dot gnu dot org" <jit at gcc dot gnu dot org>, nd <nd at arm dot com>
- Date: Mon, 1 Jul 2019 08:49:03 +0000
- Subject: Re: [PATCH][gcc] libgccjit: check result_type in gcc_jit_context_new_binary_op
- References: <gkra7epx0lv.fsf@arm.com> <1560897082.3885.10.camel@redhat.com> <gkry31rj90y.fsf@arm.com> <1561391539.3885.22.camel@redhat.com> <gkrwohbj5x6.fsf@arm.com> <1561409068.3885.28.camel@redhat.com> <gkrlfxqrsoo.fsf@arm.com> <1561555176.13494.13.camel@redhat.com> <gkrblyk9ylp.fsf@arm.com>
Andrea Corallo writes:
> David Malcolm writes:
>
>> On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote:
>>> Hi,
>>> third version for this patch with the simplified test.
>>>
>>> make check-jit pass clean
>>>
>>> Bests
>>> Andrea
>>>
>>> 2019-06-09 Andrea Corallo andrea.corallo@arm.com
>>>
>>> * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to
>>> be a
>>> numeric type.
>>>
>>>
>>> 2019-06-20 Andrea Corallo andrea.corallo@arm.com
>>>
>>> * jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c:
>>> New testcase.
>>
>> Thanks for the updated patch.
>>
>> This is good for trunk.
>>
>> (Copying and pasting from my other review): are you working on getting
>> SVN commit access, or do you want me to commit your two patches on your
>> behalf?
>>
>> Thanks
>> Dave
>
> Hi David,
> I can work on to get the SVN commit access.
> As a maintainer has to sponsor it would you mind being the one?
>
> Thanks
> Andrea
Hi David,
kind ping on this :)
Best regards
Andrea