This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch,openacc] Fix PR71959: lto dump of callee counts


On Fri, Dec 21, 2018 at 01:23:03PM +0000, Julian Brown wrote:
> 2018-xx-yy  Nathan Sidwell  <nathan@acm.org>
> 
>         PR lto/71959
>         libgomp/
>         * testsuite/libgomp.oacc-c++/pr71959-a.C: New.
>         * testsuite/libgomp.oacc-c++/pr71959.C: New.

Just nits, better use pr71959-aux.cc (*.cc files aren't considered as
testcases by *.exp:
    set tests [lsort [concat \
                          [find $srcdir/$subdir *.C] \
                          [find $srcdir/$subdir/../libgomp.oacc-c-c++-common *.c]]]
) and just a is weird.

> commit c69dce8ba0ecd7ff620f4f1b8dacc94c61984107
> Author: Julian Brown <julian@codesourcery.com>
> Date:   Wed Dec 19 05:01:58 2018 -0800
> 
>     Add testcase from PR71959
>     
>     	libgomp/

Please mention
	PR lto/71959
here in the ChangeLog.

>     	* testsuite/libgomp.oacc-c++/pr71959-a.C: New.
>     	* testsuite/libgomp.oacc-c++/pr71959.C: New.

> +void apply (int (*fn)(), Iter out) asm ("_ZN5Apply5applyEPFivE4Iter");

Will this work even on targets that use _ or other symbol prefixes?

> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.oacc-c++/pr71959.C
> @@ -0,0 +1,31 @@
> +// { dg-additional-sources "pr71959-a.C" }
> +
> +// pr lto/71959 ICEd LTO due to mismatch between writing & reading behaviour

Capital PR instead of pr .

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]