This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C++ PATCH for c++/88196, ICE with class non-type template parameter

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 20 Dec 2018 21:51:02 -0500
Subject: Re: C++ PATCH for c++/88196, ICE with class non-type template parameter
References: <20181220215403.GQ21364@redhat.com>

On 12/20/18 4:54 PM, Marek Polacek wrote:

This testcase breaks in C++20 because convert_nontype_argument gets a PTRMEM_CST
as the expression, and we're trying to convert it to a class type, which
doesn't work, but because of the PTRMEM_CST check below we never diagnosed it.

The comment says a PTRMEM_CST is a valid template argument for a parameter of
pointer to member type, but it doesn't check that that's what we're converting
it to.  Fixed by adding such a check.

Bootstrapped/regtested on x86_64-linux, ok for trunk?


OK.

Jason

References:
- C++ PATCH for c++/88196, ICE with class non-type template parameter
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]