Re: [PATCH 1/6, OpenACC, libgomp] Async re-work, interfaces (revised, v2)

[Chung-Lin Tang <chunglin_tang at mentor dot com>]

On 2018/12/15 1:52 AM, Thomas Schwinge wrote:
> As for the following changes, will you please make sure that there is one
> common order for these, used in "libgomp/libgomp-plugin.h" function
> prototypes, "libgomp/libgomp.h:acc_dispatch_t",
> "libgomp/target.c:gomp_load_plugin_for_device", "libgomp/oacc-host.c"
> function definitions as well as in "host_dispatch", and the
> libgomp-plugin(s) themselves (that's all, I think?).
>
> > --- a/libgomp/libgomp-plugin.h
> > +++ b/libgomp/libgomp-plugin.h
> > @@ -93,22 +107,31 @@ extern bool GOMP_OFFLOAD_dev2dev (int, void *, const void *, size_t);
> >   extern bool GOMP_OFFLOAD_can_run (void *);
> >   extern void GOMP_OFFLOAD_run (int, void *, void *, void **);
> >   extern void GOMP_OFFLOAD_async_run (int, void *, void *, void **, void *);
> > +
> >   extern void GOMP_OFFLOAD_openacc_exec (void (*) (void *), size_t, void **,
> > -				       void **, int, unsigned *, void *);
> > -extern void GOMP_OFFLOAD_openacc_register_async_cleanup (void *, int);
> > -extern int GOMP_OFFLOAD_openacc_async_test (int);
> > -extern int GOMP_OFFLOAD_openacc_async_test_all (void);
> > -extern void GOMP_OFFLOAD_openacc_async_wait (int);
> > -extern void GOMP_OFFLOAD_openacc_async_wait_async (int, int);
> > -extern void GOMP_OFFLOAD_openacc_async_wait_all (void);
> > -extern void GOMP_OFFLOAD_openacc_async_wait_all_async (int);
> > -extern void GOMP_OFFLOAD_openacc_async_set_async (int);
> > +				       void **, unsigned *, void *);
> > +extern void GOMP_OFFLOAD_openacc_async_exec (void (*) (void *), size_t, void **,
> > +					     void **, unsigned *, void *,
> > +					     struct goacc_asyncqueue *);
> > +extern struct goacc_asyncqueue *GOMP_OFFLOAD_openacc_async_construct (void);
> > +extern bool GOMP_OFFLOAD_openacc_async_destruct (struct goacc_asyncqueue *);
> > +extern int GOMP_OFFLOAD_openacc_async_test (struct goacc_asyncqueue *);
> > +extern void GOMP_OFFLOAD_openacc_async_synchronize (struct goacc_asyncqueue *);
> > +extern void GOMP_OFFLOAD_openacc_async_serialize (struct goacc_asyncqueue *,
> > +						  struct goacc_asyncqueue *);
> > +extern void GOMP_OFFLOAD_openacc_async_queue_callback (struct goacc_asyncqueue *,
> > +						       void (*)(void *), void *);
> > +extern bool GOMP_OFFLOAD_openacc_async_host2dev (int, void *, const void *, size_t,
> > +						 struct goacc_asyncqueue *);
> > +extern bool GOMP_OFFLOAD_openacc_async_dev2host (int, void *, const void *, size_t,
> > +						 struct goacc_asyncqueue *);

This patch revises the ordering of the above functions/hooks to be consistent
across libgomp, and un-deletes goacc_async_unmap_vars in libgomp.map.

Chung-Lin

Attachment: async-01.libgomp-interfaces.v2.patch
Description: Text document

Attachment: 01.libgomp-interfaces.v1-v2.diff
Description: Text document