This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Optimize streaming in of non-prevailing ipa-parm summaries


> On December 15, 2018 10:17:43 PM GMT+01:00, Jan Hubicka <hubicka@ucw.cz> wrote:
> >Hi,
> >this patch is motivated by finding that Firefox ipa summaries stream-in
> >is fully dominated by streaming edge summaries that are not necessary
> >because they lead to external calls or are from comdat functions that
> >are unused.
> >
> >Reading them, populating hashes and later removing them at once
> >streaming is finished increases memory use by about 1GB. This patch
> >simply adds logic to notice such unnecesary summaries early and not
> >put them to memory. This includes ADDR_EXPR that seems to be most
> >common
> >constant values and are easy to rebuild.
> 
> Don't you want to go the full way decomposing it to sym + offset? 

Hmm, it may make sense - in stats ADDR_EXPR was most common compared to
refs, but we have easy way to get sym+offset via get_ref_base_and_offset
and rebuild the tree, right?

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]