This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ICE due to cross-jumping (PR rtl-optimization/88470)


On Thu, Dec 13, 2018 at 04:28:10PM -0700, Jeff Law wrote:
> > 2018-12-13  Jakub Jelinek  <jakub@redhat.com>
> > 
> > 	PR rtl-optimization/88470
> > 	* cfgcleanup.c (outgoing_edges_match): If the function is
> > 	shrink-wrapped and bb1 ends with a JUMP_INSN with a single fake
> > 	edge to EXIT, return false.
> > 
> > 	* gcc.target/i386/pr88470.c: New test.
> OK.  Are you planning to check the other ICEs in
> maybe_record_trace_start that are in BZ to see if any are addressed by
> this change?

I will, but it is highly unlikely those are the same issues.  Computed
gotos/non-local jumps are fairly infrequent.  At least one of those is known
to be a sel-sched bug.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]