This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 09/10] Ignore LLVM's blank lines.


Hi Andrew,

> [Already approved by Jeff Law. Included here for completeness.]
>
> The GCN toolchain must use the LLVM assembler and linker because there's no
> binutils port.  The LLVM tools do not have the same diagnostic style as
> binutils, so the "blank line(s) in output" tests are inappropriate (and very
> noisy).
>
> The LLVM tools also have different command line options, so it's not possible
> to autodetect object formats in the same way.
>
> This patch addresses both issues.
>
> 2018-12-12  Andrew Stubbs  <ams@codesourcery.com>
>
> 	gcc/testsuite/
> 	* lib/file-format.exp (gcc_target_object_format): Handle AMD GCN.
> 	* lib/gcc-dg.exp (gcc-dg-prune): Ignore blank lines from the LLVM
> 	linker.
> 	* lib/target-supports.exp (check_effective_target_llvm_binutils): New.

like "exceptions", this new effective-target keyword needs documenting
in sourcebuild.texi.

> +# Return 1 if the compiler has been configured with hsa offloading.
> +
> +proc check_effective_target_offload_gcn { } {
> +    return [check_no_compiler_messages offload_gcn assembly {
> +	int main () {return 0;}
> +    } "-foffload=amdgcn-unknown-amdhsa" ]
> +}

As does this one.

> +
>  # Return 1 if the target support -fprofile-update=atomic
>  proc check_effective_target_profile_update_atomic {} {
>      return [check_no_compiler_messages profile_update_atomic assembly {
> @@ -9032,9 +9040,16 @@ proc check_effective_target_cet { } {
>      } "-O2" ]
>  }
>  
> +
>  # Return 1 if target supports floating point "infinite"
>  proc check_effective_target_inf { } {
>      return [check_no_compiler_messages supports_inf assembly {
>          const double pinf = __builtin_inf ();
>      }]
>  }

Why those additional newlines?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]