This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libgcc: rs6000: tramp.S: fix placement of .cfi_endproc for __trampoline_setup


On Wed, Dec 12, 2018 at 08:43:41AM +0100, Rasmus Villemoes wrote:
> diff --git a/libgcc/config/rs6000/tramp.S b/libgcc/config/rs6000/tramp.S
> index 637f4510146..a9f0f3826dc 100644
> --- a/libgcc/config/rs6000/tramp.S
> +++ b/libgcc/config/rs6000/tramp.S
> @@ -114,11 +114,10 @@ FUNC_START(__trampoline_setup)
>  	addi	r30,r30,_GLOBAL_OFFSET_TABLE_-1b@l
>  #endif
>  	bl	JUMP_TARGET(abort)
> +#endif
>  	.cfi_endproc
>  FUNC_END(__trampoline_setup)
>  
> -#endif
> -
>  #elif _CALL_ELF == 2
>  	.type	trampoline_initial,@object
>  	.align	3

Looks good to me.  I hadn't noticed the bad #endif placement with
respect to FUNC_END when I added .cfi_endproc, which naturally goes
with FUNC_END.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]