Re: [C++ PATCH] Fix up __builtin_is_constant_evaluated handling in array type sizes (PR c++/88446, take 2)

[Jason Merrill <jason at redhat dot com>]

On 12/11/18 4:38 PM, Jakub Jelinek wrote:
> On Tue, Dec 11, 2018 at 03:35:39PM -0500, Marek Polacek wrote:
> > >   tree
> > > -maybe_constant_value (tree t, tree decl)
> > > +maybe_constant_value (tree t, tree decl, bool pretend_const_required)
> > >   {
> > >     tree r;
> > >   
> >
> > Could you please describe the new param in the comment?
> >
> > Perhaps use /*pretend_const_required=*/true?
>
> Thanks, changed both, plus I've changed the other function's descriptions
> of that argument from the P0595R1 term (required to be const-evaluated)
> to the P0595R2 term (manifestly const-evaluated).
>
> Ok for trunk?  Or should I also change pretend_const_required argument
> name to manifestly_const_eval or something similar?

I think so, yes.  OK with that change.

Jason