This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH for c++/88216, ICE with class type in non-type template parameter


On 12/10/18 2:52 PM, Marek Polacek wrote:
+  if (processing_template_decl && value_dependent_expression_p (expr))

You don't need to check processing_template_decl before value_dependent_expression_p.

I would lean toward checking for value-dependence in convert_nontype_argument, which already does that a lot. Enough, actually, that perhaps we should remember the result in a local variable.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]