This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH for c++/88136, -Wdeprecated-copy too noisy


On Sat, Dec 08, 2018 at 06:46:27PM +0200, Ville Voutilainen wrote:
> On Thu, 6 Dec 2018 at 23:12, Jason Merrill <jason@redhat.com> wrote:
> >
> > -Wdeprecated-copy does find some real bugs, but it also complains
> > about a lot of reasonable code for which the implicitly declared copy
> > ctor/op= are fine oven though the class has a user-defined destructor:
> > this situation is only problematic if the destructor releases
> > resources held in one of the non-static data members.
> >
> > So, this patch reins it in somewhat: first by moving from -Wall to
> > -Wextra, and then also only complaining if the other copy op is
> > user-declared.  The old behavior can be explicitly requested with
> > -Wdeprecated-copy-dtor.
> 
> Hmm.
> 
> g++ -c -pipe -O2 -fPIC -std=c++1z -fvisibility=hidden
> -fvisibility-inlines-hidden -ffunction-sections -fdata-sections
> -fno-exceptions -Wall -W -Wvla -Wdate-time -Wshift-overflow=2

-W is an alias to -Wextra.

> That doesn't have -Wextra. Yet the -Wdeprecated-copy still triggers.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]