This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 10/10] Port testsuite to GCN

From: Andrew Stubbs <ams at codesourcery dot com>
To: Mike Stump <mikestump at comcast dot net>
Cc: Jeff Law <law at redhat dot com>, <gcc-patches at gcc dot gnu dot org>
Date: Thu, 6 Dec 2018 16:10:16 +0000
Subject: Re: [PATCH 10/10] Port testsuite to GCN
References: <cover.1542381960.git.ams@codesourcery.com> <2d4f15916d3fd76c3c125eca60a86f5be5b807c0.1542381960.git.ams@codesourcery.com> <bdc97e35-5152-778c-a192-42dbd92305a1@redhat.com> <693FC594-0F70-46AC-916D-C923F966ED1B@comcast.net> <0767D01A-7D1A-4FD0-84C9-47C11DDCC04D@comcast.net>

On 26/11/2018 21:13, Mike Stump wrote:

On Nov 26, 2018, at 12:04 PM, Mike Stump <mikestump@comcast.net> wrote:


I'll Ok the signal one, if you prefer it over a dummy signal routine.  Though, would be nice for you to add signal if possible/reasonable.


Oh, and my long term thinking on signal is that logically, it's fine to have:

#if __has_include("signal.h")
   signal(...);
#endif


This doesn't work here because we have signal.h (and indeed "signal").

The problem is that the function doesn't work (actually, it doesn'tlink, because "kill" is missing).

I've solved the problem by adding a machine-specific stub function inNewlib, so we can drop this portion of the patch from the testsuite now.


Andrew

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]