Re: [committed] Handle targets with 2 byte wchar_t better in strlenopt-58.c

[Martin Sebor <msebor at gmail dot com>]

On 12/5/18 12:13 PM, Jeff Law wrote:
> On 12/5/18 11:59 AM, David Edelsohn wrote:
> > Jeff,
> >
> > Thanks for the patch.
> >
> > I continue to see a failure on AIX 32 bit mode (2 byte wchar).
> >
> > FAIL: gcc.dg/strlenopt-58.c scan-tree-dump-times optimized
> > "call_in_true_branch_not_eliminated" 0
> >
> > I'm not certain if this is AIX-specific or more fallout from wchar
> > size.  I could ignore with target powerpc-ibm-aix* or with target !
> > 4byte_wchar_t.
> >
> > Any further insight / preference?
> I didn't try to address that specific failure yet -- my patch just fixed
> two earlier warnings.
>
> That specific failure either requires a deeper testsuite fix for
> possibly even a fix to the compiler -- I haven't really analyzed it yet
> (it's a failure to optimize issue and I've generally avoided looking at
> those).
>
>
> You could xfail it on 4byte_wchar_t.

I fixed similar failures in gcc.c-torture/execute/memchr-1.c some
time ago by adjusting the test (r265020) so I suspect something
along those lines would work here as well if we would rather avoid
XFAILing it.

Martin