This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3] Make function clone name numbering independent.
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Michael Ploujnikov <michael dot ploujnikov at oracle dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, Richard Guenther <richard dot guenther at gmail dot com>, Martin Jambor <mjambor at suse dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 4 Dec 2018 15:06:57 +0100
- Subject: Re: [PATCH v3] Make function clone name numbering independent.
- References: <ri636uqlx0q.fsf@suse.cz> <CAFiYyc1dadUexNFtsifE1yUa+oc2np2+Ga2h-XUzmkRkAuzBPg@mail.gmail.com> <ri6y3cik9hf.fsf@suse.cz> <3f9e8c2a-6112-b595-a932-137958e61f5e@oracle.com> <ded14873-6181-849f-6a3e-faf804d3f097@oracle.com> <CAFiYyc0RqvSYCzBpHYwufN4DKMSf9au_NFj2pGjqic7WCefe-A@mail.gmail.com> <fa12f39f-6d95-c3ab-39f9-06481239e234@oracle.com> <CAMe9rOo_JMw6H61K8-T6kHtoOeGeeP5K+Sxpw-a1-pOfRnCyrQ@mail.gmail.com> <af5b054d-68d7-6aec-65b3-9cac4771f7b4@oracle.com> <faca2e7e-0266-a9b3-9d84-95988bc31229@oracle.com>
> On 2018-12-03 12:00 p.m., Michael Ploujnikov wrote:
> > On 2018-12-01 11:29 a.m., H.J. Lu wrote:
> >> This caused:
> >>
> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88297
> >>
> >
> > Sorry about that. Looks like I should have been testing with
> > --with-build-config=bootstrap-lto rather than just --enable-bootstrap.
> >
> > The quick fix would be to undo the patch to create_virtual_clone or to
> > just change clone_num_suffixes to key off of DECL_ASSEMBLER_NAME
> > (node->decl) instead of node pointers. Any preferences?
> >
> > The harder fix would be to figure out why some nodes share the same
> > names and fix that, but maybe that's just inevitable with LTO?
> >
> > - Michael
> >
>
> Here's a quick fix while the issue is being investigated.
>
> Bootstrapped (--with-build-config=bootstrap-lto) and regtested on x86_64.
>
> Ok for trunk?
> From f5e2500f30ad337e85e0b53eaa15c724657966a2 Mon Sep 17 00:00:00 2001
> From: Michael Ploujnikov <michael.ploujnikov@oracle.com>
> Date: Mon, 3 Dec 2018 18:19:18 -0500
> Subject: [PATCH] PR ipa/88297
>
> gcc/ChangeLog:
>
> 2018-12-03 Michael Ploujnikov <michael.ploujnikov@oracle.com>
>
> PR ipa/88297
> * ipa-cp.c (create_specialized_node): Store clone counters by
> node assembler names.
> (ipcp_driver): Change type of clone_num_suffixes key type to
> const char*.
OK,
thanks!
Honza