This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][OpenACC] Update deviceptr handling during gimplification


On Tue, Aug 07, 2018 at 03:09:38PM -0700, Cesar Philippidis wrote:
> I had previously posted this patch as part of a monster deviceptr patch
> here <https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01911.html>. This
> patch breaks out the generic gimplifier changes. Essentially, with this
> patch, the gimplifier will now transfer deviceptr data clauses using
> GOMP_MAP_FORCE_DEVICEPTR.
> 
> Is this patch OK for trunk? It bootstrapped / regression tested cleanly
> for x86_64 with nvptx offloading.

See my comments on the monster deviceptr patch.
> 
> 2018-XX-YY  Cesar Philippidis  <cesar@codesourcery.com>
> 
> 	gcc/fortran/
> 	* trans-openmp.c (gfc_omp_finish_clause): Don't create pointer data
> 	mappings for deviceptr clauses.
> 	(gfc_trans_omp_clauses): Likewise.
> 	gcc/
> 	* gimplify.c (enum gimplify_omp_var_data): Add GOVD_DEVICETPR.
> 	(omp_notice_variable): Add GOVD_DEVICEPTR attribute when appropriate.
> 	(gimplify_scan_omp_clauses): Likewise.
> 	(gimplify_adjust_omp_clauses_1): Set GOMP_MAP_FORCE_DEVICEPTR for
> 	implicit deviceptr mappings.
> 	gcc/testsuite/
> 	* c-c++-common/goacc/deviceptr-4.c: Update expected data mapping.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]