This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC][AArch64] Add support for system register based stack protector canary access
- From: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: James Greenhalgh <James dot Greenhalgh at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ard Biesheuvel <ard dot biesheuvel at linaro dot org>, Will Deacon <Will dot Deacon at arm dot com>, Mark Rutland <Mark dot Rutland at arm dot com>, nd <nd at arm dot com>
- Date: Mon, 3 Dec 2018 10:03:36 +0000
- Subject: Re: [RFC][AArch64] Add support for system register based stack protector canary access
- References: <7a5a57fa-629d-d2ff-6292-e0893647ec8a@arm.com> <20181203095919.GT12380@tucnak>
On 03/12/2018 09:59, Jakub Jelinek wrote:
> On Mon, Dec 03, 2018 at 09:55:36AM +0000, Ramana Radhakrishnan wrote:
>> + if (aarch64_stack_protector_guard == SSP_GLOBAL
>> + && opts->x_aarch64_stack_protector_guard_offset_str)
>> + {
>> + error ("Incompatible options -mstack-protector-guard=global and"
>
> Diagnostic messages shouldn't start with capital letters (3 times in the
> patch), unless it is something that is capitalized always, even in the
> middle of sentences (say GNU etc.).
>
> Jakub
>
Sorry - will fix in next iteration.
Ramana