This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Adjust offsets for present data clauses
- From: Thomas Schwinge <thomas at codesourcery dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: <cltang at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, <Catherine_Moore at mentor dot com>
- Date: Fri, 30 Nov 2018 21:23:15 +0100
- Subject: Re: [PATCH] Adjust offsets for present data clauses
- References: <b296bf2d-1071-93a7-17d7-c3d685bee220@codesourcery.com> <b8a49785-0950-2ed7-4a05-f0e7950056c7@mentor.com> <20181130103709.40df644a@squid.athome>
Hi Julian!
On Fri, 30 Nov 2018 10:37:09 +0000, Julian Brown <julian@codesourcery.com> wrote:
> > On 2018/7/21 6:07 AM, Cesar Philippidis wrote:
> > > This is another old gomp4 patch that corrects a bug where the
> > > runtime was passing the wrong offset for subarray data to the
> > > accelerator. The original description of this patch can be found
> > > here <https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01676.html>
> This one will be superseded
Well, this is clearly a bug, so should be addressed independently. I
just filed <https://gcc.gnu.org/PR88288> "[OpenACC, libgomp] Adjust
offsets for present data clauses". (Better late than never...)
> by the attach/detach patch, I think (where
> the additional offset is added also, via calling "gomp_map_val".
Aha, good to know: during review, I wondered about whether that function
should actually be used. (But it also isn't in other places in
"libgomp/target.c".)
Grüße
Thomas