Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

[Mike Gulick <mgulick at mathworks dot com>]

On 11/13/18 3:12 PM, David Malcolm wrote:
> On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote:
>> 2018-11-13  Mike Gulick  <mgulick@mathworks.com>
> 
> [...]
> 
>> 	* gcc/diagnostic-core.h (num_digits): Add extern definition.
> 
> FWIW you moved the decl to diagnostic.h, but didn't update the above
> ChangeLog entry.
> 
> [...]
> 
>> diff --git a/libcpp/location-example.txt b/libcpp/location-
>> example.txt
>> index 14b5c2e284a..dc448b0493e 100644
>> --- a/libcpp/location-example.txt
>> +++ b/libcpp/location-example.txt
> 
> You're going to need to regenerate this file again; I touched many of
> the same lines as your patch does, in r266085 (sorry).
> 

Thanks.  I updated this file and fixed the changelog.  I will send an
updated patch after this email.  The contents of this file were a little
stale, so many of the locations in the file have changed in addition to
the fields I added.  I verified that the changed locations aren't due to
any of these patches.

> Other than the nits above, this looks good to me (once you have your
> contribution paperwork in place).

The contribution paperwork is now in place.  There are no other changes
to the previous patches (other than updating the changelog date).
Please let me know if there is anything else I need to do.

Thanks,
Mike