This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix tree-ssa/phi-opt-11.c on s390x (PR testsuite/85368)
- From: Andreas Krebbel <krebbel at linux dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Mike Stump <mikestump at comcast dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 23 Nov 2018 15:43:01 +0100
- Subject: Re: [PATCH] Fix tree-ssa/phi-opt-11.c on s390x (PR testsuite/85368)
- References: <20181122195654.GJ11625@tucnak>
On 22.11.18 20:56, Jakub Jelinek wrote:
> Hi!
>
> This test apparently FAILs on s390x-linux, which is an effective target of
> both logical_op_short_circuit and branch_cost.
> The test has
> /* { dg-additional-options "-mbranch-cost=2" { target branch_cost } } */
> and that option effectively makes the target ! logical_op_short_circuit,
> but the effective target just reflects the default setting. So, I think
> it should expect 0 ifs rather than 2 if -mbranch-cost=2 is used and
> 2 when that option isn't used.
>
> Tested on x86_64-linux (which is a branch_cost but not logical_op_short_circuit
> effective target), Andreas, does this fix it on s390x-linux (I've only
> looked at the optimized dump using a cross-compiler)?
Yes it does. Thanks for having a look!
Andreas