This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH, i386]: Fix PR88051, internal compiler error: in add_clobbers


Hello!

There are actually two problems discovered:

a) The insn condition of floatunsdidf2 is incorrect, it allows 32bit
AVX512F targets, but these are not necessarily
KEEP_VECTOR_ALIGNED_STACK targets.

b) movdi_to_sse is defined with extra parallel encapsulation.
Instructions in this form don't get registered to add_clobbers, so we
trigger assert for unknown insn ID there.

Attached patch fixes both problems. However, with the fixed pattern,
RA for some reason insists on spilling DImode register to memory, so I
rewrote the whole pattern as UNSPEC.

2018-11-16  Uros Bizjak  <ubizjak@gmail.com>

    PR target/88051
    * config/i386/i386.md (floatunsdidf2): Allow only 64bit AVX512F targets.
    * config/i386/sse.md (UNSPEC_MOVDI_TO_SSE): New UNSPEC.
    (movdi_to_sse): Rewrite using UNSPEC_MOVDI_TO_SSE unspec.

Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

Committed to mainline SVN. The fix for pattern will be backported to
other release branches.

Uros.

Attachment: p.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]