This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Committed][AArch64] Fix PR62178 testcase failures
Hi Segher,
> On Wed, Nov 14, 2018 at 12:37:05PM +0000, Wilco Dijkstra wrote:
>> +/* { dg-final { scan-assembler-not { dup } } } */
>> +/* { dg-final { scan-assembler-not { fmov } } } */
>
> { dup } is the same as " dup " , that is, with spaces and all.
> I don't think you want that (there usually is a tab character before
> mnemonics, so \s would work better, or use \m and \M. Or nothing,
> just delete the spaces, if you are sure nothing in the generated
> assembler code says "dup").
Thanks for spotting that! I removed the spaces (below). The syntax is
arcane to say the least but it seems {} has fewer bugs in regular expressions.
I can never figure out how many \ to use so it works exactly identically across
different regexp/tcl versions.
Wilco
--- gcc/testsuite/gcc.target/aarch64/pr62178.c (revision 266178)
+++ gcc/testsuite/gcc.target/aarch64/pr62178.c (working copy)
@@ -18,5 +18,5 @@
/* { dg-final { scan-assembler "ldr\\tq\[0-9\]+, \\\[x\[0-9\]+\\\], \[0-9\]+" } } */
/* { dg-final { scan-assembler "mla\\tv\[0-9\]+\.4s, v\[0-9\]+\.4s, v\[0-9\]+" } } */
-/* { dg-final { scan-assembler-not { dup } } } */
-/* { dg-final { scan-assembler-not { fmov } } } */
+/* { dg-final { scan-assembler-not {dup} } } */
+/* { dg-final { scan-assembler-not {fmov} } } */