This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] Fix two grokdeclarator locations

From: Jason Merrill <jason at redhat dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 13 Nov 2018 19:30:22 -0500
Subject: Re: [C++ Patch] Fix two grokdeclarator locations
References: <4f8f3e21-9b13-76af-eed0-341687a86e2d@oracle.com> <ecdfe7c0-ad95-457a-be56-7ea4016dd3ce@oracle.com>

On 11/12/18 6:39 AM, Paolo Carlini wrote:

Hi again,

On 08/11/18 10:26, Paolo Carlini wrote:
Hi,
two additional grokdeclarator locations that we can easily fix byusing declarator->id_loc. Slightly more interesting, testing revealeda latent issue in the make_id_declarator uses:cp_parser_member_declaration wasn't setting declarator->id_loc, thus Idecided to add a location_t parameter to make_id_declarator itself andadjust all the callers. Tested x86_64-linux.
PS: In my local tree I have the cp_parser_objc_class_ivars change usingtoken->location instead of UNKNOWN_LOCATION, thus all themake_id_declarator calls should be completely fine location-wise.


Great, I was going to ask about that.  Can I see that patch, then?

Jason

Follow-Ups:
- Re: [C++ Patch] Fix two grokdeclarator locations
  - From: Paolo Carlini

References:
- [C++ Patch] Fix two grokdeclarator locations
  - From: Paolo Carlini
- Re: [C++ Patch] Fix two grokdeclarator locations
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]