This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][lower-subreg] Fix PR87507

From: Peter Bergner <bergner at linux dot ibm dot com>
To: Richard Henderson <rth at twiddle dot net>, Eric Botcazou <ebotcazou at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org, "ian at airs dot com" <ian at airs dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>
Date: Tue, 13 Nov 2018 13:09:30 -0600
Subject: Re: [PATCH][lower-subreg] Fix PR87507
References: <27077db7-b4bf-689c-2438-a5bab4753871@linux.ibm.com> <4040235.T82DKmk4EN@polaris> <fed50e49-267b-c39a-320c-9db1a368f4f0@linux.ibm.com> <0aec7522-1ce5-2448-455a-2864c436d98c@twiddle.net>

On 11/13/18 12:49 PM, Richard Henderson wrote:
> On 11/13/18 5:38 PM, Peter Bergner wrote:
>> On 11/13/18 2:53 AM, Eric Botcazou wrote:
>>> Superfluous semi-colon.  Given that the function returns an operand, its name 
>>> is IMO misleading, so maybe [get_]operand_for_simple_move_operator.
>>
>> Fixed and renamed function to operand_for_simple_move_operator.
> 
> Would not operand_for_swap_move_operator be better?  This is not a "simple
> move", it is something that requires swapping the words of the operand.
> (Presumably one could think of other operators that generate a swap, and match
> them here.  I can't think of another one off the top of my head though.)

That's fine with me.

Peter

References:
- [PATCH][lower-subreg] Fix PR87507
  - From: Peter Bergner
- Re: [PATCH][lower-subreg] Fix PR87507
  - From: Eric Botcazou
- Re: [PATCH][lower-subreg] Fix PR87507
  - From: Peter Bergner
- Re: [PATCH][lower-subreg] Fix PR87507
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]