This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Instrument only selected files (PR gcov-profile/87442).


On 11/9/18 11:00 PM, Jeff Law wrote:
> On 11/8/18 6:42 AM, Martin Liška wrote:
>> Hi.
>>
>> The patch is about possibility to filter which files are instrumented. The usage
>> is explained in the PR.
>>
>> Patch can bootstrap and survives regression tests on x86_64-linux-gnu.
>>
>> Ready for trunk?
>> Thanks,
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2018-11-08  Martin Liska  <mliska@suse.cz>
>>
>> 	PR gcov-profile/87442
>> 	* common.opt: Add -fprofile-filter-files and -fprofile-exclude-files
>> 	options.
>> 	* doc/invoke.texi: Document them.
>> 	* tree-profile.c (parse_profile_filter): New.
>> 	(parse_profile_file_filtering): Likewise.
>> 	(release_profile_file_filtering): Likewise.
>> 	(include_source_file_for_profile): Likewise.
>> 	(tree_profiling): Filter source files based on the
>> 	newly added options.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2018-11-08  Martin Liska  <mliska@suse.cz>
>>
>> 	PR gcov-profile/87442
>> 	* gcc.dg/profile-filtering-1.c: New test.
>> 	* gcc.dg/profile-filtering-2.c: New test.
> Extra credit if we could also do this on a function level.  I've
> certainly talked to developers that want finer grained control over what
> gets instrumented and what doesn't.  This is probably enough to help
> them, but I'm sure they'll want more :-)
> 
> 
> OK.
> jeff
> 

Hi.

May I consider this Jeff as approval of the patch?

Thanks,
Martin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]