This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls
- From: Sudakshina Das <Sudi dot Das at arm dot com>
- To: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Mihail Ionescu <mihail dot ionescu at foss dot arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, "rguenth at suse dot de" <rguenth at suse dot de>
- Date: Thu, 8 Nov 2018 18:53:46 +0000
- Subject: Re: [PATCH, arm] Backport -- Fix ICE during thunk generation with -mlong-calls
- References: <23fcdf27-a6ee-79b1-4e5a-21ef0782ef99@foss.arm.com> <657bb415-3d05-90a8-f2df-14aa402c8718@arm.com>
Hi Mihail
On 08/11/18 10:02, Ramana Radhakrishnan wrote:
> On 07/11/2018 17:49, Mihail Ionescu wrote:
>> Hi All,
>>
>> This is a backport from trunk for GCC 8 and 7.
>>
>> SVN revision: r264595.
>>
>> Regression tested on arm-none-eabi.
>>
>>
>> gcc/ChangeLog
>>
>> 2018-11-02 Mihail Ionescu <mihail.ionescu@arm.com>
>>
>> Backport from mainiline
>> 2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
>>
>> * config/arm/arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
>> (arm32_output_mi_thunk): Deal with long calls.
>>
>> gcc/testsuite/ChangeLog
>>
>> 2018-11-02 Mihail Ionescu <mihail.ionescu@arm.com>
>>
>> Backport from mainiline
>> 2018-09-17 Eric Botcazou <ebotcazou@adacore.com>
>>
>> * g++.dg/other/thunk2a.C: New test.
>> * g++.dg/other/thunk2b.C: Likewise.
>>
>>
>> If everything is ok, could someone commit it on my behalf?
>>
>> Best regards,
>> Mihail
>>
>
> It is a regression since my rewrite of this code.
>
> Ok to backport to the release branches, it's been on trunk for a while
> and not shown any issues - please give the release managers a day or so
> to object.
>
> regards
> Ramana
>
Does this fix PR87867 you reported? If yes, then it would be easier
to add the PR tag in the ChangeLog so that the ticket gets updated once
committed.
Thanks
Sudi