This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/6] [RS6000] Replace TLSmode with P, and correct tls call mems
On Wed, Nov 07, 2018 at 04:08:26PM +1030, Alan Modra wrote:
> There is really no need to define a TLSmode mode iterator that is
> identical (since !TARGET_64BIT == TARGET_32BIT) to the much used P
> mode iterator.
Nice :-)
> It's nonsense to think we might ever want to support
> 32-bit TLS on 64-bit or vice versa! The patch also fixes a minor
> error in the call mems. All other direct calls use (call (mem:SI ..)).
You can also replace <tls_abi_suffix> with <bits>, <tls_sysv_suffix> with
<mode>, and l<tls_insn_suffix> with <ptrload>. Also, was "TLSmode:"
needed anywhere? I don't see any other iterator used in those patterns.
> * config/rs6000/rs6000.md (TLSmode): Delete mode iterator. Replace
> with P throughout except for call mems which should use SI.
Approved for trunk. Further cleanup as above pre-approved. Thanks!
Segher