This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Stafford Horne <shorne at gmail dot com>
- Cc: nd <nd at arm dot com>, GCC patches <gcc-patches at gcc dot gnu dot org>, Openrisc <openrisc at lists dot librecores dot org>, Richard Henderson <rth at twiddle dot net>, Jeff Law <law at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Joel Sherrill <joel at rtems dot org>, Sebastian Huber <sebastian dot huber at embedded-brains dot de>, Rich Felker <dalias at libc dot org>
- Date: Mon, 5 Nov 2018 11:13:53 +0000
- Subject: Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc
- References: <20181027043702.18414-1-shorne@gmail.com> <20181027043702.18414-4-shorne@gmail.com> <29809b24-23e5-9981-df88-6550f7f91b4c@arm.com> <20181104090544.GB16938@lianli.shorne-pla.net>
On 04/11/18 09:05, Stafford Horne wrote:
> On Mon, Oct 29, 2018 at 02:28:11PM +0000, Szabolcs Nagy wrote:
>> On 27/10/18 05:37, Stafford Horne wrote:
...
>>> +#undef LINK_SPEC
>>> +#define LINK_SPEC "%{h*} \
>>> + %{static:-Bstatic} \
>>> + %{shared:-shared} \
>>> + %{symbolic:-Bsymbolic} \
>>> + %{!static: \
>>> + %{rdynamic:-export-dynamic} \
>>> + %{!shared:-dynamic-linker " GNU_USER_DYNAMIC_LINKER "}}"
>>> +
>>> +#endif /* GCC_OR1K_LINUX_H */
>>
>> note that because of the -static-pie mess each
>> target needs a more complicated LINK_SPEC now.
>
> Hello,
>
> Does something like this look better?
>
> --- a/gcc/config/or1k/linux.h
> +++ b/gcc/config/or1k/linux.h
> @@ -37,8 +37,9 @@
> %{static:-Bstatic} \
> %{shared:-shared} \
> %{symbolic:-Bsymbolic} \
> - %{!static: \
> + %{!static:%{!static-pie: \
> %{rdynamic:-export-dynamic} \
> - %{!shared:-dynamic-linker " GNU_USER_DYNAMIC_LINKER "}}"
> + %{!shared:-dynamic-linker " GNU_USER_DYNAMIC_LINKER "}}} \
> + %{static-pie:-Bstatic -pie --no-dynamic-linker -z text}"
>
> #endif /* GCC_OR1K_LINUX_H */
looks ok.
> I have tested this out with or1k-linux-musl, but I get some LD complaints i.e.
>
> .../or1k-linux-musl/bin/ld: .../or1k-linux-musl/lib/libc.a(exit.o): non-pic relocation against symbol __fini_array_end
> .../or1k-linux-musl/bin/ld: .../or1k-linux-musl/lib/libc.a(exit.o): non-pic relocation against symbol __fini_array_start
>
> Those are some warnings we recently added to LD, perhaps I need to rebuild the
> libc.a with PIE as well. I will try it out, but if anyone has some suggestions
> that would be helpful.
yes, musl does not build libc.a with pic by default,
either use a gcc configured with --enable-default-pie
or CC='gcc -fPIC' when building musl.
after that -static-pie linking should work.
(maybe musl should have an --enable-static-pie config
option to make this simpler)