Re: [PATCH, testsuite] test case fixes for pdp11

[Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>]

Hi Paul,

> This patch fixes a number of test case failures on pdp11.  Some are too large for the address space, some have dependencies on the float format that don't match the DEC format, some add pdp11 to the targets that expect particular compiler messages.

unfortunately, even apart from the two bugs in your patch Andreas
already fixed, there are more problems: with the patch one gets 20
warnings

WARNING: compat.exp does not support dg-skip-if

in mail-report.log for gcc.dg/compat.  While the message is misleading
and it took me a moment to understand what's wrong, you should have
found this in your testing.  A good way something like this doesn't go
unnoticed in a regtest is to run make mail-report.log in a vanilla and
patched tree and compare the output.  Those WARNING and ERROR lines are
prominent there for a reason ;-)

While we give target maintainers quite a bit of leeway to apply
testsuite patches affecting only their targets, this needs to be
exercised with caution.  Best test the modified testsuite on a different
target, too, to check that it doesn't break there.

Besides, a bit more detail on the failures you observe without your
patch would have been helpful.  I noticed that some of the tests you
change already have dg-skip-if directives for avr with a comment of
"Program too big".  It's hard to tell if this is the same issue as your
"limited code space".  If so, it would be advisable and much more
expressive to introduce (yet another) effective-target keyword for this.

The problem is that in the g??.dg/compat testsuites, dg keywords except
for dg-options are only supposed to go into the *_main.c file.  The
following patch fixes this.  Tested on i386-pc-solaris2.11 and
sparc-sun-solaris2.11, installed on mainline.
         
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2018-11-02  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gcc/testsuite:
	* gcc.dg/compat/pr83487-1_y.c: Move dg-skip-if ...
	* gcc.dg/compat/pr83487-1_main.c: ... here.
	* gcc.dg/compat/struct-by-value-10_main.c,
	gcc.dg/compat/struct-by-value-10_x.c,
	gcc.dg/compat/struct-by-value-11_main.c,
	gcc.dg/compat/struct-by-value-11_x.c,
	gcc.dg/compat/struct-by-value-12_main.c,
	gcc.dg/compat/struct-by-value-12_x.c,
	gcc.dg/compat/struct-by-value-13_main.c,
	gcc.dg/compat/struct-by-value-13_x.c,
	gcc.dg/compat/struct-by-value-14_main.c,
	gcc.dg/compat/struct-by-value-14_x.c,
	gcc.dg/compat/struct-by-value-15_main.c,
	gcc.dg/compat/struct-by-value-15_x.c,
	gcc.dg/compat/struct-by-value-17_main.c,
	gcc.dg/compat/struct-by-value-17_x.c,
	gcc.dg/compat/struct-by-value-18_main.c,
	gcc.dg/compat/struct-by-value-18_x.c,
	gcc.dg/compat/struct-by-value-2_main.c,
	gcc.dg/compat/struct-by-value-2_x.c,
	gcc.dg/compat/struct-by-value-22_main.c,
	gcc.dg/compat/struct-by-value-22_x.c,
	gcc.dg/compat/struct-by-value-3_main.c,
	gcc.dg/compat/struct-by-value-3_x.c,
	gcc.dg/compat/struct-by-value-4_main.c,
	gcc.dg/compat/struct-by-value-4_x.c,
	gcc.dg/compat/struct-by-value-5b_main.c,
	gcc.dg/compat/struct-by-value-5b_x.c,
	gcc.dg/compat/struct-by-value-6b_main.c,
	gcc.dg/compat/struct-by-value-6b_x.c,
	gcc.dg/compat/struct-by-value-6b_main.c,
	gcc.dg/compat/struct-by-value-7b_x.c,
	gcc.dg/compat/struct-by-value-7b_main.c,
	gcc.dg/compat/struct-by-value-8_main.c,
	gcc.dg/compat/struct-by-value-8_x.c,
	gcc.dg/compat/struct-by-value-9_main.c,
	gcc.dg/compat/struct-by-value-9_x.c,
	gcc.dg/compat/struct-return-2_main.c,
	gcc.dg/compat/struct-return-2_x.c: Likewise.

# HG changeset patch
# Parent  3b32766f9b2fd59fd2ced721fe452cceb2bd0f7c
Move gcc.dg/compat dg-skip-if to *_main.c files

diff --git a/gcc/testsuite/gcc.dg/compat/pr83487-1_main.c b/gcc/testsuite/gcc.dg/compat/pr83487-1_main.c
--- a/gcc/testsuite/gcc.dg/compat/pr83487-1_main.c
+++ b/gcc/testsuite/gcc.dg/compat/pr83487-1_main.c
@@ -1,3 +1,5 @@
+/* { dg-skip-if "no large alignment" { pdp11-*-* } } */
+
 extern void do_test (void);
 
 int
diff --git a/gcc/testsuite/gcc.dg/compat/pr83487-1_y.c b/gcc/testsuite/gcc.dg/compat/pr83487-1_y.c
--- a/gcc/testsuite/gcc.dg/compat/pr83487-1_y.c
+++ b/gcc/testsuite/gcc.dg/compat/pr83487-1_y.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "no large alignment" { pdp11-*-* } } */
-
 #include "pr83487-1.h"
 
 struct A a;
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-10_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-10_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-10_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-10_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are floating
    point scalars.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_10_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-10_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-10_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-10_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-10_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp2-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-11_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-11_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-11_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-11_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are of type
    _Complex char.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_11_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-11_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-11_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-11_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-11_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-12_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-12_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-12_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-12_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are of type
    _Complex short.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_12_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-12_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-12_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-12_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-12_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-13_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-13_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-13_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-13_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are type
    _Complex int.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_13_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-13_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-13_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-13_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-13_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-14_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-14_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-14_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-14_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are of type
    _Complex long.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_14_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-14_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-14_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-14_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-14_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-15_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-15_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-15_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-15_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are of type
    _Complex long long.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_15_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-15_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-15_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-15_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-15_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-16_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-16_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-16_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-16_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-17_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-17_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-17_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-17_main.c
@@ -2,6 +2,7 @@
    variable-length argument lists.  All struct members are of type
    _Complex double.  */
 /* { dg-skip-if "Program too big" { "avr-*-*" } } */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_17_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-17_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-17_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-17_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-17_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-18_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-18_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-18_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-18_main.c
@@ -2,6 +2,7 @@
    variable-length argument lists.  All struct members are of type
    _Complex long double.  */
 /* { dg-skip-if "Program too big" { "avr-*-*" } } */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_18_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-18_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-18_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-18_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-18_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-22_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-22_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-22_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-22_main.c
@@ -1,4 +1,6 @@
 /* { dg-require-effective-target alloca } */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
+
 /* Test variable sized function argument passing.
    GCC 3.2 and earlier is incompatible with GCC 3.3+ on x86-64,
    the latter passes variable sized arguments by reference while
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-22_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-22_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-22_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-22_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #ifndef SKIP_VLA_IN_STRUCT
 
 #ifndef T
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-2_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-2_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-2_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-2_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument list.
    This test is based on one contributed by Alan Modra.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_2_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-2_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-2_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-2_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-2_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #define T(N, NAME, TYPE)					\
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-3_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-3_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-3_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-3_main.c
@@ -2,6 +2,7 @@
    variable-length argument list.  All struct members are scalar
    integral types, and the structs are "small": 1, 2, 4, 8, and 12
    bytes for LP64.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_3_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-3_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-3_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-3_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-3_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #define T(TYPE)							\
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-4_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-4_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-4_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-4_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument list.  Each struct contains an array
    of small structs with a single member.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_4_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-4_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-4_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-4_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-4_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #define T(N, TYPE)						\
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are float
    scalars.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_5b_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-5b_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are double
    scalars.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_6b_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-6b_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument lists.  All struct members are long double
    scalars.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_7b_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-7b_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #include "fp-struct-defs.h"
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-8_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-8_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-8_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-8_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument list.  Each struct contains an array
    of small structs with two scalar members.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_8_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-8_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-8_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-8_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-8_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #define T(N, TYPE)						\
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-9_main.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-9_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-9_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-9_main.c
@@ -1,6 +1,7 @@
 /* Test structures passed by value, including to a function with a
    variable-length argument list.  Each struct contains an array
    of small structs, each with three scalar members.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_by_value_9_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-by-value-9_x.c b/gcc/testsuite/gcc.dg/compat/struct-by-value-9_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-by-value-9_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-by-value-9_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #define T(N, TYPE)						\
diff --git a/gcc/testsuite/gcc.dg/compat/struct-return-2_main.c b/gcc/testsuite/gcc.dg/compat/struct-return-2_main.c
--- a/gcc/testsuite/gcc.dg/compat/struct-return-2_main.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-return-2_main.c
@@ -1,5 +1,6 @@
 /* Test function return values.  This test includes structs that are
    arrays of unsigned integral scalars.  */
+/* { dg-skip-if "limited code space" { pdp11-*-* } } */
 
 extern void struct_return_2_x (void);
 extern void exit (int);
diff --git a/gcc/testsuite/gcc.dg/compat/struct-return-2_x.c b/gcc/testsuite/gcc.dg/compat/struct-return-2_x.c
--- a/gcc/testsuite/gcc.dg/compat/struct-return-2_x.c
+++ b/gcc/testsuite/gcc.dg/compat/struct-return-2_x.c
@@ -1,5 +1,3 @@
-/* { dg-skip-if "limited code space" { pdp11-*-* } } */
-
 #include "compat-common.h"
 
 #ifdef SKIP_VA