This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: V2 [PATCH] i386: Use scalar operand in SF/DF/SI/DI vec_dup patterns


On Tue, Oct 30, 2018 at 9:36 PM H.J. Lu <hjl.tools@gmail.com> wrote:

> > Why not at the expand time? Rewrite vector constant as vec_duplicate
> > from memory and combine will do the stuff for you. We do have _bcst
> > instruction patterns.
> >
>
> Here is the updated patch to do that.  OK for trunk?

Looks mostly good, however IMO we should move the expansion out of
ix86_expand_args_builtin. We have an example of
ix86_expand_unop_vec_merge_builtin and VEC_MERGE type in
i386-builtin-types.def on how to handle special builtins.

Uros.

> Thanks.
>
>
> --
> H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]