This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] combine: Fix various shortcomings in make_more_copies (PR87701, PR87780)
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 29 Oct 2018 02:49:14 -0500
- Subject: Re: [PATCH] combine: Fix various shortcomings in make_more_copies (PR87701, PR87780)
- References: <aebb76ab9573c5f10b8ca356bfaab419446462bf.1540797565.git.segher@kernel.crashing.org> <CA+=Sn1mKgjqPv4oEmB_0_Wt0gsaYRkXQmY4TpanFysTaij+6PQ@mail.gmail.com>
On Mon, Oct 29, 2018 at 12:31:28AM -0700, Andrew Pinski wrote:
> > PR rtl-optimization/87701
> > PR rtl-optimization/87780
> > * combine.c (make_more_copies): Rewrite.
>
> I think a better changelog would be :):
> * combine.c (make_more_copies): Rewrite to be simplier.
But it is not simpler at all now: *not* removing old notes while changing
RTL instructions is a very bad idea often; and modifying instructions
while not being very careful upsets DF. It may *look* simple now ;-)
Segher