This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2, rs6000 4/4] Add compatible implementations of x86 SSSE3 intrinsics <tmmintrin.h>
On 10/26/2018 02:02 PM, Bill Schmidt wrote:
> On 10/25/18 2:08 PM, Paul Clarke wrote:
>> diff --git a/trunk/gcc/testsuite/gcc.target/powerpc/ssse3-check.h b/trunk/gcc/testsuite/gcc.target/powerpc/ssse3-check.h
>> new file mode 10644
>> --- /dev/null (revision 0)
>> +++ b/trunk/gcc/testsuite/gcc.target/powerpc/ssse3-check.h (working copy)
>> @@ -0,0 +1,43 @@
>> +#include <stdio.h>
>> +#include <stdlib.h>
>> +
>> +#include "m128-check.h"
>> +
>> +/* define DEBUG replace abort with printf on error. */
>
> One nit -- this comment appears to be incorrect, as the only place DEBUG is used,
> you don't have abort() anywhere.
>
> (I have a patch under review that questions why we would replace abort() rather
> than supplement it with printf, anyway...)
You are correct. That comment was copied without consideration, is incorrect, and should just be deleted. It looks like the abort() issue you are fixing in your patch is not present in the new(-ish) test cases in this patch.
I'll commit a new (trivial/obvious) change.
PC