This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Intrinsic compatibility tests should not pass just because DEBUG is set
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Bill Schmidt <wschmidt at linux dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 26 Oct 2018 14:03:29 -0500
- Subject: Re: [PATCH, rs6000] Intrinsic compatibility tests should not pass just because DEBUG is set
- References: <674c2386-63ed-c345-c75b-21161ba52d29@linux.ibm.com>
Hi Bill,
On Thu, Oct 25, 2018 at 02:58:59PM -0500, Bill Schmidt wrote:
> A number of the test cases for the intrinsic compatibility headers are set up
> to dump more information when a test case fails and the DEBUG macro has been
> set. Unfortunately, many of them also then pass the test case since they no
> longer call abort(). This patch fixes that oversight (or intentional oddity).
>
> A lot of these tests are also miserably formatted, so I took the liberty of
> cleaning that up while I was in here.
>
> Tested on powerpc64le-linux-gnu with no failures. Is this ok for trunk, and
> potential backport to 8?
Sure, that's fine. Thanks!
Segher