This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH for decomp31.C test
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Fri, 12 Oct 2018 10:09:57 +0200
- Subject: Re: C++ PATCH for decomp31.C test
- References: <20181012013951.GM19003@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Oct 11, 2018 at 09:39:51PM -0400, Marek Polacek wrote:
> Running make check-c++ RUNTESTFLAGS=dg.exp=decomp31.C will yield
> # of unsupported tests 3
> because the test (as the only one in cpp1z/) uses
> "dg-do compile { target c++17 }" which doesn't work (yet?). This patch
> makes it use explicit dg-options as in other tests, so now we get
> # of expected passes 1
>
> Tested on x86_64-linux, ok for trunk?
I wrote it that way so that it is tested not just with -std=c++17, but also
with -std=c++2a and -std=c++17 -fconcepts.
I wonder if we shouldn't finally make the default testing include C++17 in
addition to 98/11/14, or if we plan to do that, whether we are going through
tests with such dg-options -std=c++17 and convert them back to { target
c++17 } if appropriate.
> 2018-10-11 Marek Polacek <polacek@redhat.com>
>
> * g++.dg/cpp1z/decomp31.C: Use explicit dg-options.
>
> --- gcc/testsuite/g++.dg/cpp1z/decomp31.C
> +++ gcc/testsuite/g++.dg/cpp1z/decomp31.C
> @@ -1,5 +1,6 @@
> // PR c++/81888
> -// { dg-do compile { target c++17 } }
> +// { dg-do compile }
> +// { dg-options "-std=c++17" }
>
> struct S {
> bool s = true;
Jakub