This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS: Default to --with-llsc for the R5900 Linux target as well


Hi Fredrik,

> The Linux kernel requires and emulates LL and SC for the R5900 too. The

 Two spaces after a full stop please (in commit descriptions too).

> special --without-llsc default for the R5900 is therefore not applicable
> in that case.

 I cannot formally approve your change, but it looks good if not obviously
correct to me.  Therefore:

Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>

I hope this helps you get a general maintainer's approval.

 Also your change is small enough to be acceptable right away without a 
copyright assignment to FSF, however I do recommend that you make one for 
GCC as well (and also glibc and possibly GDB), as I imagine you'll come up 
with more changes as you progress with your effort.

 Thank you for your contribution!

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]