Re: [C++ Patch] PR 84423 ("[6/7/8/9 Regression] [concepts] ICE with invalid using declaration")

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi again,

On 9/28/18 9:15 PM, Paolo Carlini wrote:
> Thanks. About the location, you are certainly right, but doesn't seem 
> trivial. Something we can do *now* is using 
> declspecs->locations[ds_typedef] and declspecs->locations[ds_alias], 
> but that gives us the location of the keyword 'typedef' and 'using', 
> respectively, whereas I think that we would like to have the location 
> of 'auto' itself. I could look into that as a follow-up piece work

In fact, completing the work turned out to be easy: ensure that 
cp_parser_alias_declaration saves the location of the defining-type-id 
too and then consistently use locations[ds_type_spec] in the error 
messages. Tested x86_64-linux. Still Ok? ;)

Thanks, Paolo.

///////////////////

Attachment: CL_84423_2
Description: Text document

Attachment: patch_84423_2
Description: Text document