This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[committed] Fix _mm512_{,mask_}abs_pd (PR target/87467)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 29 Sep 2018 18:29:24 +0200
- Subject: [committed] Fix _mm512_{,mask_}abs_pd (PR target/87467)
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
Hi!
These two functions were copied from their _mm512_*abs_ps counterparts and
weren't fully adjusted, plus avx512f-abspd-1.c testcase was identical to
avx512f-absps-1.c and thus nothing caught this up in the testsuite.
Sorry for that.
Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
committed to trunk, 8 and 7 branches as obvious.
2018-09-29 Jakub Jelinek <jakub@redhat.com>
PR target/87467
* config/i386/avx512fintrin.h (_mm512_abs_pd, _mm512_mask_abs_pd): Use
__m512d type for __A argument rather than __m512.
* gcc.target/i386/avx512f-abspd-1.c (SIZE): Divide by two.
(CALC): Use double instead of float.
(TEST): Adjust to test _mm512_abs_pd and _mm512_mask_abs_pd rather than
_mm512_abs_ps and _mm512_mask_abs_ps.
--- gcc/config/i386/avx512fintrin.h.jj 2018-07-11 22:55:44.660456510 +0200
+++ gcc/config/i386/avx512fintrin.h 2018-09-29 10:29:46.731170222 +0200
@@ -7798,7 +7798,7 @@ _mm512_mask_abs_ps (__m512 __W, __mmask1
extern __inline __m512d
__attribute__ ((__gnu_inline__, __always_inline__, __artificial__))
-_mm512_abs_pd (__m512 __A)
+_mm512_abs_pd (__m512d __A)
{
return (__m512d) _mm512_and_epi64 ((__m512i) __A,
_mm512_set1_epi64 (0x7fffffffffffffffLL));
@@ -7806,7 +7806,7 @@ _mm512_abs_pd (__m512 __A)
extern __inline __m512d
__attribute__ ((__gnu_inline__, __always_inline__, __artificial__))
-_mm512_mask_abs_pd (__m512d __W, __mmask8 __U, __m512 __A)
+_mm512_mask_abs_pd (__m512d __W, __mmask8 __U, __m512d __A)
{
return (__m512d)
_mm512_mask_and_epi64 ((__m512i) __W, __U, (__m512i) __A,
--- gcc/testsuite/gcc.target/i386/avx512f-abspd-1.c.jj 2017-04-07 21:20:58.092845868 +0200
+++ gcc/testsuite/gcc.target/i386/avx512f-abspd-1.c 2018-09-29 10:25:59.062006644 +0200
@@ -6,11 +6,11 @@
#include "avx512f-helper.h"
-#define SIZE (AVX512F_LEN / 32)
+#define SIZE (AVX512F_LEN / 64)
#include "avx512f-mask-type.h"
static void
-CALC (float *i1, float *r)
+CALC (double *i1, double *r)
{
int i;
@@ -24,27 +24,27 @@ CALC (float *i1, float *r)
void
TEST (void)
{
- float ck[SIZE];
+ double ck[SIZE];
int i;
- UNION_TYPE (AVX512F_LEN, ) s, d, dm;
+ UNION_TYPE (AVX512F_LEN, d) s, d, dm;
MASK_TYPE mask = MASK_VALUE;
for (i = 0; i < SIZE; i++)
{
- s.a[i] = i * ((i & 1) ? 3.5f : -7.5f);
+ s.a[i] = i * ((i & 1) ? 3.5 : -7.5);
d.a[i] = DEFAULT_VALUE;
dm.a[i] = DEFAULT_VALUE;
}
CALC (s.a, ck);
- d.x = INTRINSIC (_abs_ps) (s.x);
- dm.x = INTRINSIC (_mask_abs_ps) (dm.x, mask, s.x);
+ d.x = INTRINSIC (_abs_pd) (s.x);
+ dm.x = INTRINSIC (_mask_abs_pd) (dm.x, mask, s.x);
- if (UNION_CHECK (AVX512F_LEN, ) (d, ck))
+ if (UNION_CHECK (AVX512F_LEN, d) (d, ck))
abort ();
- MASK_MERGE () (ck, mask, SIZE);
- if (UNION_CHECK (AVX512F_LEN, ) (dm, ck))
+ MASK_MERGE (d) (ck, mask, SIZE);
+ if (UNION_CHECK (AVX512F_LEN, d) (dm, ck))
abort ();
}
Jakub