This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][OpenACC] Update deviceptr handling during gimplification
- From: Cesar Philippidis <cesar_philippidis at mentor dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: "gcc-patches at gnu dot org" <gcc-patches at gnu dot org>
- Date: Wed, 26 Sep 2018 06:35:28 -0700
- Subject: Re: [PATCH][OpenACC] Update deviceptr handling during gimplification
- References: <d5b8ad7d-59b2-051b-c9a1-b5db68b580e6@mentor.com> <20180926015554.18556bb2@squid.athome>
On 09/25/2018 05:55 PM, Julian Brown wrote:
> On Tue, 7 Aug 2018 15:09:38 -0700
> Cesar Philippidis <cesar_philippidis@mentor.com> wrote:
>
>> I had previously posted this patch as part of a monster deviceptr
>> patch here
>> <https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01911.html>. This
>> patch breaks out the generic gimplifier changes. Essentially, with
>> this patch, the gimplifier will now transfer deviceptr data clauses
>> using GOMP_MAP_FORCE_DEVICEPTR.
>>
>> Is this patch OK for trunk? It bootstrapped / regression tested
>> cleanly for x86_64 with nvptx offloading.
>
> This patch also appears to fix the attached test case, which had been
> associated with a different deviceptr-related patch on the og8 branch
> (the other parts of which are upstream already). Perhaps you'd like to
> incorporate this test into your patch? It was by James Norris
> originally, IIUC.
Ok, I'll do that. Thanks for updating those tests.
Cesar