This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[Patch, fortran] PR70149 - [F08] Character pointer initialization causes ICE
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 25 Sep 2018 17:43:45 +0100
- Subject: [Patch, fortran] PR70149 - [F08] Character pointer initialization causes ICE
This is yet another deferred length character bug. The fix speaks for
itself. I'll dream up a more suitable name for the testcase before
committing.
Bootstraps and regtests on FC21/x86_64 - OK for trunk and 8-branch?
Paul
2018-09-25 Paul Thomas <pault@gcc.gnu.org>
PR fortran/70149
* trans-decl.c (gfc_get_symbol_decl): A deferred character
length pointer that is initialized needs the string length to
be initialized as well.
2018-09-25 Paul Thomas <pault@gcc.gnu.org>
PR fortran/70149
* gfortran.dg/pr70149.f90 : New test.
diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c
index 159c3dbb..f7568d5 100644
--- a/gcc/fortran/trans-decl.c
+++ b/gcc/fortran/trans-decl.c
@@ -1759,7 +1759,17 @@ gfc_get_symbol_decl (gfc_symbol * sym)
&& TREE_CODE (sym->ts.u.cl->backend_decl) != INDIRECT_REF)
{
gfc_finish_var_decl (length, sym);
- gcc_assert (!sym->value);
+ if (!sym->attr.associate_var
+ && TREE_CODE (length) == VAR_DECL
+ && sym->value && sym->value->ts.u.cl->length)
+ {
+ gfc_expr *len = sym->value->ts.u.cl->length;
+ DECL_INITIAL (length) = gfc_conv_initializer (len, &len->ts,
+ TREE_TYPE (length),
+ false, false, false);
+ }
+ else
+ gcc_assert (!sym->value);
}
gfc_finish_var_decl (decl, sym);
! { dg-do run }
!
! Test the fix for PR70149 in which the string length for
! 'number_string' was not initialized.
!
! Contributed by Walter Spector <w6ws@earthlink.net>
!
module myptr_mod
implicit none
integer, target, save :: int_data = 42
character(16), target, save :: char_data = 'forty two'
integer, pointer :: number => int_data
character(:), pointer :: number_string => char_data
end module
use myptr_mod
if (LEN (number_string) .ne. 16) stop 1
if (trim (number_string) .ne. 'forty two') stop 2
end