This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: VRP: undefined shifting calculation should not need sign bit
- From: Jeff Law <law at redhat dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 11 Sep 2018 16:59:41 -0600
- Subject: Re: VRP: undefined shifting calculation should not need sign bit
- References: <1ab7411f-d602-5aa6-4b4a-02c066d693a3@redhat.com>
On 9/11/18 4:09 AM, Aldy Hernandez wrote:
> We can calculate wide_int_range_shift_undefined_p() without having to
> pass down the sign bit of the operand. Also, vrp_shift_undefined_p is a
> brain dead wrapper so I'm removing it.
>
> OK for trunk?
>
> curr.patch
>
> commit 9aeb62d4c33b50bc007b07ec5097e8f3edd4b31b
> Author: Aldy Hernandez <aldyh@redhat.com>
> Date: Mon Sep 10 17:46:10 2018 +0200
>
> * tree-vrp.c (vrp_shift_undefined_p): Remove.
> (extract_range_from_binary_expr_1: Call
> wide_int_range_shift_undefined_p instead of vrp_shift_undefined_p.
> * wide-int-range.h (wide_int_range_shift_undefined_p): Do not
> depend on sign.
OK
jeff