This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PING][PATCH][debug] Add -gdescribe-dies
- From: Tom de Vries <tdevries at suse dot de>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Richard Biener <rguenther at suse dot de>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Cary Coutant <ccoutant at gmail dot com>
- Date: Tue, 11 Sep 2018 17:32:09 +0200
- Subject: [PING][PATCH][debug] Add -gdescribe-dies
- References: <20180815140258.GA1999@delia> <alpine.LSU.2.20.1808201447260.16707@zhemvz.fhfr.qr> <21062fd5-5697-8da0-44ea-1f0c14e81f33@suse.de> <077f3e77-79b8-4f33-a135-990a885cf999@suse.de> <dffcde34-420e-1b70-88cc-834dc0d3fcea@suse.de> <516e20a1-0a30-958c-7cd2-848a4879dc4a@suse.de> <alpine.LSU.2.20.1808241236430.16707@zhemvz.fhfr.qr> <20180824153819.GA18240@delia> <CADzB+2ny5dr7Q3kF2SDsdUY+Tq+Kcf92yZg9VJRJDYGKS_G6rw@mail.gmail.com> <ef558954-ccd0-bee6-5bea-76d0b154c166@suse.de>
On 09/01/2018 08:10 PM, Tom de Vries wrote:
>> Please add more of this description to the one-line documentation
>> patch you have now;
> Done.
>
>> there are many DIEs that have no name because they
>> don't need one, and this patch doesn't add names to all of them.
>>
> I've added the qualification "some" (to both documentation and command
> line option description).
>
>> These two cases seem like they have very different uses, but I suppose
>> we don't really need two new options.
> In both cases we add a description of the DIE. Could you explain what
> the difference in usage you refer to is?
>
> Attached patch (which I will merge with the posted patch pre-commit)
> fixes up documentation and command line option description.
>
> OK?
>
Ping.
Thanks,
- Tom
>
>
> 0002-fixup.patch
>
>
> fixup
>
> ---
> gcc/common.opt | 2 +-
> gcc/doc/invoke.texi | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/common.opt b/gcc/common.opt
> index f41f8f74b30..ef6a63087af 100644
> --- a/gcc/common.opt
> +++ b/gcc/common.opt
> @@ -2978,7 +2978,7 @@ Don't emit DWARF additions beyond selected version.
>
> gdescribe-dies
> Common Driver Report Var(flag_describe_dies) Init(0)
> -Add description attributes to DWARF DIEs that have no name attribute.
> +Add description attributes to some DWARF DIEs that have no name attribute.
>
> gtoggle
> Common Driver Report Var(flag_gtoggle)
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index b06189f73ce..d7cf30ad2d1 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -7468,7 +7468,9 @@ files.
>
> @item -gdescribe-dies
> @opindex gdescribe-dies
> -Add description attributes to DWARF DIEs that have no name attribute.
> +Add description attributes to some DWARF DIEs that have no name attribute,
> +such as artificial variables, external references and call site
> +parameter DIEs.
>
> @item -gpubnames
> @opindex gpubnames