This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,FORTRAN 09/29] Use stringpool for modules
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: Fortran List <fortran at gcc dot gnu dot org>,aldot at gcc dot gnu dot org,GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 05 Sep 2018 22:58:49 +0200
- Subject: Re: [PATCH,FORTRAN 09/29] Use stringpool for modules
- References: <CAC1BbcSJmqmQW7Zuv+6UQu0znbsVm85i3gP_y4Dny3czMCANgA@mail.gmail.com> <20180905145732.404-10-rep.dot.nop@gmail.com> <CAO9iq9EGrrU2nwE-z1Qd756yKgnDHxz+BrrQ5+igk2Z_N0rPMw@mail.gmail.com>
On 5 September 2018 20:44:05 CEST, Janne Blomqvist <blomqvist.janne@gmail.com> wrote:
>On Wed, Sep 5, 2018 at 6:00 PM Bernhard Reutner-Fischer <
>rep.dot.nop@gmail.com> wrote:
>
>> diff --git a/gcc/fortran/match.c b/gcc/fortran/match.c
>> index 38827ed4637..6596bd87c09 100644
>> --- a/gcc/fortran/match.c
>> +++ b/gcc/fortran/match.c
>> @@ -1274,15 +1274,22 @@ not_yes:
>> case '%':
>> matches++;
>> break; /* Skip. */
>> +#if 0
>> + /* If everybody is disciplined we do not need to reset
>this.
>> */
>> + case 'n':
>> + vp = va_arg (argp, void **); /* FORNOW: NULL shouldn't
>be */
>> + *vp = NULL;
>> + break;
>> +#else
>> + case 'n':
>> +#endif
>>
>
>Some debugging leftover that should be removed?
Well AFAIR this still blew up at some point. It's possible that this would work out fine now that all %n should be converted.
I'll have another look.