This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] [match.pd]: missing optimization on comparison
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org,Marc Glisse <marc dot glisse at inria dot fr>,Kai Tietz <ktietz70 at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 02 Sep 2018 12:14:34 +0200
- Subject: Re: [patch] [match.pd]: missing optimization on comparison
- References: <CAEwic4bhtQECeixVzcFmgo5C1mHqGCOPB+L=qy8xrRFYYfvZxg@mail.gmail.com> <CAEwic4Z=iKpSohF1xy3WPjSvCCUT6s+Q42dfc+yY1Z03ztxn3g@mail.gmail.com> <alpine.DEB.2.21.1808302051440.22400@stedding.saclay.inria.fr>
On 30 August 2018 22:20:06 CEST, Marc Glisse <marc.glisse@inria.fr> wrote:
>Hello,
>
>INTEGRALS_SIGN_PREC_MATCH: the name doesn't really match the semantics.
+#define INTEGRALS_SIGN_PREC_MATCH(A, B) \
+ TYPE_PRECISION (TREE_TYPE (A)) == TYPE_PRECISION (TREE_TYPE (B)) \
+ (TYPE_PRECISION (TREE_TYPE (A)) > TYPE_PRECISION (TREE_TYPE (B)) \
+ && !TYPE_UNSIGNED (TREE_TYPE (B)))
+
Unless my mailer somehow mangled it, isn't there some operator ( maybe || ?) missing between the eq clause and the second one?
How comes that it even compiles, presumably without a warning?
thanks,