This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] IPA ICF: make type cache a static field sem_item.
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, flo at usrdev dot de
- Date: Fri, 31 Aug 2018 13:32:21 +0200
- Subject: Re: [PATCH] IPA ICF: make type cache a static field sem_item.
- References: <3d1ae8d1-a03e-76d6-d1bf-880ae2671e0e@suse.cz>
On Fri, Aug 31, 2018 at 12:49 PM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> As noticed here:
> https://gcc.gnu.org/ml/gcc/2018-08/msg00004.html
>
> There's ugly usage of a static variable in sem_item_optimizer
> that's called from sem_item.
>
> I believe logically the hash should live in sem_item.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
OK.
> Martin
>
>
> gcc/ChangeLog:
>
> 2018-08-29 Martin Liska <mliska@suse.cz>
>
> * ipa-icf.c (sem_item::add_type): Use
> sem_item::m_type_hash_cache.
> * ipa-icf.h: Move the cache from sem_item_optimizer
> to sem_item.
> ---
> gcc/ipa-icf.c | 6 ++++--
> gcc/ipa-icf.h | 6 +++---
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
>