This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/3] or1k: gcc: initial support for openrisc
On Tue, Aug 28, 2018 at 08:13:48AM -0600, Jeff Law wrote:
> On 08/26/2018 03:18 PM, Stafford Horne wrote:
> > yyyy-mm-dd Stafford Horne <shorne@gmail.com>
> > Richard Henderson <rth@twiddle.net>
> >
> > gcc/ChangeLog:
> >
> > * common/config/or1k/or1k-common.c: New file.
> > * config/or1k/*: New.
> > * config.gcc (or1k*-*-*): New.
> > * configure.ac (or1k*-*-*): New test for openrisc tls.
> > * configure: Regenerated.
> So I still want to do another looksie, but a few comments beyond what
> Joseph has already pointed out.
>
> Many functions are documented with "WORKER for xyz." kinds of comments.
> Policy is each function should have a comment which describes what the
> function does at a high level as well as the inputs/outputs.
I will work on cleaning up the comments. I am hoping the OpenRISC port would be
a easy to understand port for RISC processes for others getting started. Fixing
these comments will really help with that.
The other points Richard has expressed on his reply. Ill also add some
commentary there.
Thank you for the review.
-Stafford