This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix MIPS builds
On Mon, 2018-08-27 at 10:27 -0600, Jeff Law wrote:
> External Email
>
> On 08/27/2018 09:55 AM, Steve Ellcey wrote:
> >
> > On Sun, 2018-08-26 at 20:56 -0600, Jeff Law wrote:
> > >
> > > MIPS builds have been failing to build due to trying to use an
> > > incomplete struct function type. The uses are coming from cfg.h which
> > > typically isn't included in the target files.
> > >
> > > Fixed by including "backend.h" and removing the "cfg.h"
> > > inclusion.
> > >
> > > THere's likely other targets (aarch64?) that are suffering from a
> > > similar problem and could likely be fixed in a similar way. I'll look
> > > at those once I'm confident all my MIPS targets are building
> > > again.
> > >
> > > jeff
> > I tried this change in gcc/config/aarch64/aarch64-speculation.cc
> > (changing include of cfg.h to backend.h) and it fixed my build problem.
> Go ahead and commit it :-) backend.h seems like an appropriate thing to
> include there.
>
> jeff
OK, here is the patch I will check in:
2018-08-27 Steve Ellcey <sellcey@cavium.com>
* config/aarch64/aarch64-speculation.cc: Replace include of cfg.h
with include of backend.h.
diff --git a/gcc/config/aarch64/aarch64-speculation.cc b/gcc/config/aarch64/aarch64-speculation.cc
index 2dd06ae..3cd9ba0 100644
--- a/gcc/config/aarch64/aarch64-speculation.cc
+++ b/gcc/config/aarch64/aarch64-speculation.cc
@@ -25,7 +25,7 @@
#include "rtl.h"
#include "tree-pass.h"
#include "profile-count.h"
-#include "cfg.h"
+#include "backend.h"
#include "cfgbuild.h"
#include "print-rtl.h"
#include "cfgrtl.h"