This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix aarch64_evpc_tbl guard (PR 85910)
- From: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
- To: gcc-patches at gcc dot gnu dot org, james dot greenhalgh at arm dot com, marcus dot shawcroft at arm dot com, richard dot sandiford at arm dot com
- Date: Thu, 23 Aug 2018 15:44:53 +0100
- Subject: Re: Fix aarch64_evpc_tbl guard (PR 85910)
- References: <874lflv51k.fsf@arm.com>
On 23/08/18 09:52, Richard Sandiford wrote:
> This patch fixes a typo in aarch64_expand_vec_perm_const_1 that I
> introduced as part of the SVE changes. I don't know of any cases in
> which it has any practical effect, since we'll eventually try to use
> TBL as a variable permute instead. Having the code is still an
> important part of defining the interface properly and so we shouldn't
> simply drop it.
>
> Tested on aarch64-linux-gnu (with and without SVE) and aarch64_be-elf.
> Applied as obvious to trunk, but OK to backport to GCC 8?
>
Yes.
R.
> Richard
>
>
> 2018-08-23 Richard Sandiford <richard.sandiford@arm.com>
>
> gcc/
> PR target/85910
> * config/aarch64/aarch64.c (aarch64_expand_vec_perm_const_1): Fix
> aarch64_evpc_tbl guard.
> ------------------------------------------------------------------------------
>
> Index: gcc/config/aarch64/aarch64.c
> ===================================================================
> --- gcc/config/aarch64/aarch64.c 2018-08-23 09:47:55.000000000 +0100
> +++ gcc/config/aarch64/aarch64.c 2018-08-23 09:48:51.379223625 +0100
> @@ -15461,7 +15461,7 @@ aarch64_expand_vec_perm_const_1 (struct
> return true;
> if (d->vec_flags == VEC_SVE_DATA)
> return aarch64_evpc_sve_tbl (d);
> - else if (d->vec_flags == VEC_SVE_DATA)
> + else if (d->vec_flags == VEC_ADVSIMD)
> return aarch64_evpc_tbl (d);
> }
> return false;
>