This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: m68k: handle more cases of TLS symbols with offset


On 08/09/2018 10:25 AM, Andreas Schwab wrote:
> On Aug 09 2018, Gunther Nikl <gnikl@justmail.de> wrote:
> 
>> FWIW, the prototype for m68k_final_prescan_insn in m68k-protos.h was
>> not removed.
> 
> Thanks, fixed.
> 
> Andreas.
> 
> 	* config/m68k/m68k-protos.h (m68k_final_prescan_insn): Remove
> 	prototype.
> 
> diff --git a/gcc/config/m68k/m68k-protos.h b/gcc/config/m68k/m68k-protos.h
> index 1f6a68f62b..f412db9b31 100644
> --- a/gcc/config/m68k/m68k-protos.h
> +++ b/gcc/config/m68k/m68k-protos.h
> @@ -67,7 +67,6 @@ extern rtx m68k_function_value (const_tree, const_tree);
>  extern int emit_move_sequence (rtx *, machine_mode, rtx);
>  extern bool m68k_movem_pattern_p (rtx, rtx, HOST_WIDE_INT, bool);
>  extern const char *m68k_output_movem (rtx *, rtx, HOST_WIDE_INT, bool);
> -extern void m68k_final_prescan_insn (rtx_insn *, rtx *, int);
>  extern bool m68k_epilogue_uses (int);
>  
>  /* Functions from m68k.c used in constraints.md.  */
> 
There's also an unused variable in m68k_adjust_decorated_operand which
causes bootstrap to fail.

/src/gcc/gcc/config/m68k/m68k.c: In function 'void
m68k_adjust_decorated_operand(rtx)':
/src/gcc/gcc/config/m68k/m68k.c:2337:7: error: unused variable 'i'
[-Werror=unused-variable]
   int i;
       ^
I'm committing the attached patch as an obvious fix.  The tester will
spin it overnight.



Jeff
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index dfe1c7c8e0f..b215706ccfa 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-09  Jeff Law  <law@redhat.com>
+
+	* config/m68k/m68k.c (m68k_adjust_decorated_operand): Remove
+	unused variable.
+
 2018-08-09  Andreas Schwab  <schwab@linux-m68k.org>
 
 	* config/m68k/m68k-protos.h (m68k_final_prescan_insn): Remove
diff --git a/gcc/config/m68k/m68k.c b/gcc/config/m68k/m68k.c
index 303dfc1c0c9..ea4154583b1 100644
--- a/gcc/config/m68k/m68k.c
+++ b/gcc/config/m68k/m68k.c
@@ -2334,8 +2334,6 @@ m68k_unwrap_symbol (rtx orig, bool unwrap_reloc32_p)
 static void
 m68k_adjust_decorated_operand (rtx op)
 {
-  int i;
-
   /* Combine and, possibly, other optimizations may do good job
      converting
        (const (unspec [(symbol)]))

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]