This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] improve internals documentation for nested function descriptors
- From: Paul Koning <paulkoning at comcast dot net>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Fri, 27 Jul 2018 16:45:20 -0400
- Subject: Re: [patch] improve internals documentation for nested function descriptors
- References: <34513faf-01d3-2d6d-79b8-bd627b108bfd@codesourcery.com>
> On Jul 27, 2018, at 4:39 PM, Sandra Loosemore <sandra@codesourcery.com> wrote:
>
> Apropos of the discussion about improving the docs for TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port submission,
>
> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html
>
> here is the patch I've come up with based on reading the source. Is this technically accurate? Any suggestions on how to improve it further?
>
> -Sandra
> <descriptor.log><descriptor.patch>
Nice. That tells me a lot more, so I hope to hear confirmation it's accurate.
A nit: "word aligned" -- you used thas as a synonym for "multiple of 4 aligned" but some of us have 2-byte words.
On the function descriptor concept generally: it wasn't clear to me whether a target that wants to use this mechanism needs to do anything to tell GCC how to construct descriptors. Does GCC have a standard recipe it uses that "should" work for any target? I assume so because there aren't any other target hooks or special patterns for this. It would be helpful to say so explicitly.
paul