This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Limix dump_flag enum values range (PR middle-end/86645).


On Tue, Jul 24, 2018 at 9:27 AM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> That fixes many UBSAN issues that are caused by:
>
>   {"all", dump_flags_t (~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_GRAPH
>                         | TDF_STMTADDR | TDF_RHS_ONLY | TDF_NOUID
>                         | TDF_ENUMERATE_LOCALS | TDF_SCEV | TDF_GIMPLE))},
>
> That goes out of:
>
>       minv = TYPE_MIN_VALUE (TREE_TYPE (type));
>       maxv = TYPE_MAX_VALUE (TREE_TYPE (type));
>
> Thus I would like to limit value of "all".
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
> And UBSAN errors are gone.
>
> Ready to be installed?

OK.

Richard.

> Martin
>
>
> gcc/ChangeLog:
>
> 2018-07-23  Martin Liska  <mliska@suse.cz>
>
>         PR middle-end/86645
>         * dumpfile.c: And excluded values with TDF_ALL_VALUES.
>         * dumpfile.h (enum dump_flag): Defince TDF_ALL_VALUES.
> ---
>  gcc/dumpfile.c | 7 ++++---
>  gcc/dumpfile.h | 5 ++++-
>  2 files changed, 8 insertions(+), 4 deletions(-)
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]